Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.154.3 #3941

Closed
wants to merge 1 commit into from
Closed

v0.154.3 #3941

wants to merge 1 commit into from

Conversation

xlgmokha
Copy link
Contributor

v0.154.3, 19 June 2021

  • fix: Fetches upload-pack using git if http fails
  • fix(Terraform): handle dependencies without a namespace
  • chore: Replace wget with curl for minimized dependency
  • chore: add lint job to check shell scripts
  • build(deps): bump @npmcli/arborist in /npm_and_yarn/helpers
  • chore: Double quote variables in Dockerfile's shellscript, cc Double quote variables in shellscript #3917

v0.154.2...1b17a40

@xlgmokha xlgmokha requested a review from a team as a code owner June 19, 2021 18:06
Copy link
Contributor

@thepwagner thepwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I wondered about the (unwritten) attribution policy.
Since it's not written, not a blocker. :shipit:

@@ -1,3 +1,12 @@
## v0.154.3, 19 June 2021

- fix: Fetches upload-pack using git if http fails
Copy link
Contributor

@thepwagner thepwagner Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: some of these are community contributions, do those contributors want a shout-out?

I tend to include a (@awesome-contributor) for anyone outside GitHub's Dependabot team as means of thanks and encouragement.
It's one of those weird things that's done sometimes but not written down anywhere. We could not care, we could write it down, or encode it in the bump-version script

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great idea.

- chore: Replace wget with curl for minimized dependency
- chore: add lint job to check shell scripts
- build(deps): bump @npmcli/arborist in /npm_and_yarn/helpers
- chore: Double quote variables in Dockerfile's shellscript, cc #3917
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to copy this to a new release as I merged a few changes without spotting this release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this @feelepxyz.

@feelepxyz feelepxyz closed this Jun 21, 2021
@feelepxyz feelepxyz deleted the v0.154.3-release-notes branch June 21, 2021 13:28
@feelepxyz
Copy link
Contributor

#3957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants