Fix multiple Python requirements separated by whitespace #5735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Given that these are non-standard and only supported by poetry, I'd suggest adding code comments for each of these three code blocks. Something simple like:
# Standard python doesn't support whitespace in requirements, but Poetry does.
I realize it's in the commit log, but still it's too easy to not understand why this is needed in the logic / tests otherwise.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/odd-poetry-reqs
branch
from
29b9e2e
to
9807a0e
Compare
|
also, why did poetry go this route? 🤦 |
deivid-rodriguez
force-pushed
the
deivid-rodriguez/odd-poetry-reqs
branch
from
9807a0e
to
1f74249
Compare
|
I have no idea, but seems much better than Python ignoring (but not erroring out) all requirements after the first if you don't split them with commas 🤯. |
Standard Python does not support this, but Poetry does, so when they appear on Poetry dependency files, they make dependabot crash.
jeffwidman
force-pushed
the
deivid-rodriguez/odd-poetry-reqs
branch
from
1f74249
to
aaf292f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard Python does not support this, but Poetry does, so when they appear on Poetry dependency files, they make dependabot crash.
Fixes #5363.