-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show ignore conditions in a request body #7654
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cc8f922
Added ignore condition to message buidler
honeyankit 7bed28a
added rspec test for ignore conditions on PR body
honeyankit c644c70
Simplified the test loop in rspec for ignore conditions
honeyankit 653f73f
check ignore conditon's dependency with dependencies in the pull request
honeyankit b76b02a
added check to generate the collapsible section when html tag is supp…
honeyankit 9a0e90f
removed commented code from the message_builder
honeyankit ed1bafa
Fixed all lint issues
honeyankit 237e0b0
Fix failing test after adding ignore_conditions to job instance double
honeyankit ca4115b
added feature support for unignore_commands
honeyankit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@honeyankit where does this
from_config_file
value come from? I don't see it in https://github.com/github/dependabot-api/blob/9fc5f8ad58c303bb9a1df9e460ee812d5350e797/app/models/update_job.rb#L184-L187There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jurre: We also need to modify this function. My earlier assumption was wrong about the attributes of ignore_conditions, We have to replace
from_config_file
withsource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source will contain string with info whether it was invoked via config file or via
@dependabot ignore command
. It will have to match the ignore command here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have implemented
@dependbot show <dep -name> ignore conditions
which is something similar to this. You can get context from that and modify theignore_conditions_table
method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the field
created_at
andupdated_at
in update job on this PR: https://github.com/github/dependabot-api/pull/4319