-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix edge cases during semver grouping creating single PRs erroneously #7867
fix edge cases during semver grouping creating single PRs erroneously #7867
Conversation
e35cfb9
to
5ee63e8
Compare
The specs have shown an issue and now I'm seeing both groups and dependency_snapshots have Wait, no the dependency engine populates the group dependencies... !? Edit 74: After studying the code, I think the failing specs are misleading. Now that we're in the world where |
I need to add a test and then this will be ready to go. |
This pushes the "handled" logic into the group so that the
compile_updates_for
method can specify that the dependency is handled immediately when it is found to be in the semver grouping. This way, if there is an error or the update is not possible, it will still be considered handled and not attempt to create a single PR for it.Also, if an exception is thrown, even during version fetching before we can know whether it's in the grouping or not, we consider the dependency handled as well since it's not known what versions are available. Customers can request a rebase or recreate to try again and not have superfluous PRs kicking about.