Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker variant with matching digests not updating correctly #9043

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

brbayes-msft
Copy link
Contributor

@brbayes-msft brbayes-msft commented Feb 13, 2024

There is an issue where the text replacement when a duplicate digest was present for dockerfile did not look for the dependency name or tag, only the old digest. This updates the code to look for all of the components based on what was present in the original file.

@github-actions github-actions bot added the L: docker Docker containers label Feb 13, 2024
@brbayes-msft brbayes-msft marked this pull request as ready for review February 13, 2024 16:01
@brbayes-msft brbayes-msft requested a review from a team as a code owner February 13, 2024 16:01
@brbayes-msft brbayes-msft changed the title Fix docker variant with digests not updating correctly Fix docker variant with matching digests not updating correctly Feb 13, 2024
Copy link
Contributor

@honeyankit honeyankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@honeyankit honeyankit force-pushed the brbayes/fix-docker-variant-with-digest branch from 85a9fc6 to 776eeab Compare February 13, 2024 17:48
@honeyankit honeyankit merged commit 5afddae into main Feb 13, 2024
55 checks passed
@honeyankit honeyankit deleted the brbayes/fix-docker-variant-with-digest branch February 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: docker Docker containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants