Update all the things #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
xmr/dev
branch
4 times, most recently
from
1a58ed1 to
52646db
Compare
XhmikosR
commented
Apr 24, 2023
XhmikosR
force-pushed
the
xmr/dev
branch
9 times, most recently
from
8d85804 to
0d2b4ab
Compare
XhmikosR
commented
May 3, 2023
index.js
Outdated
| @@ -34,7 +34,7 @@ module.exports = function(options = {}) { | |||
| return config.isListForm ? [] : {}; | |||
| } | |||
|
|
|||
| const results = traverse(config); | |||
| const results = module.exports._traverse(config); | |||
There was a problem hiding this comment.
Not super happy with this approach, but I don't know how to achieve the same with another package and rewire is buggy and sort of unmaintained.
If someone knows another package to replace rewire and achieve the same result without exporting stuff just for testing, let me know.
|
@mrjoelkemp please check #157 (comment) I actually dropped the relevant code but I'm not sure if everything's still covered. Exporting stuff just for testing is bad, though, so I'm not sure which way to go. |
XhmikosR
force-pushed
the
xmr/dev
branch
3 times, most recently
from
3b01ded to
769e369
Compare
* Drop Node.js < 14 support * Remove debug dependency * Fix tests on Windows * Switch to GitHub Actions CI * Add c8 for coverage * Update dependencies * Kept back mocha due to test failures Rewire and esm should be dropped later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESM and rewire are causing issues. @mrjoelkemp would be nice if you could drop them like you did in dependents/node-filing-cabinet#105
TODO:
Closes #155, closes #154 while at it