Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added permission to execut #9

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Added permission to execut #9

merged 1 commit into from
Apr 14, 2021

Conversation

taqie
Copy link
Contributor

@taqie taqie commented Mar 11, 2021

Added permission to execut

Added permission to execut
@@ -46,6 +46,7 @@ function dep() {

if (!dep) {
execa.commandSync('curl -LO https://deployer.org/deployer.phar')
execa.commandSync('sudo chmod +x deployer.phar')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work with sudo command here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I don't tested that solution because I did this action for testing

> name: Deploy
> on:
>   push:
>     branches: [ master ]
>   pull_request:
>     branches: [ master ]
>   workflow_dispatch:
> jobs:
>   deploy:
>     name: deploy to prod
>     runs-on: ubuntu-latest
>     steps:
>       - uses: actions/checkout@v1
>       - name: Setup PHP
>         uses: shivammathur/setup-php@v2
>         with:
>           php-version: 8.0
>       - name: SetUp Deployer
>         run: curl -LO https://deployer.org/deployer.phar && mkdir bin && mv deployer.phar bin/dep && sudo chmod +x bin/dep
>       - name: Deploy
>         uses: deployphp/action@master
>         with:
>           private-key: ${{ secrets.PRIVATE_KEY }}
>           known-hosts: ${{ secrets.KNOWN_HOSTS }}
>           dep: test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonmedv Have you tested this solution?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and the sudo command work

@RdeWilde
Copy link

When will this one be merged? Is atm a showstopper for me, or is there a simple workaround?

@antonmedv antonmedv merged commit 4b3c564 into deployphp:master Apr 14, 2021
@lamasfoker
Copy link

@RdeWilde You can use shivammathur/setup-php@v2 action and specify deployer in the tools parameter. Take a look at this.

@RdeWilde
Copy link

RdeWilde commented May 5, 2021

Thanks for merging @antonmedv , is there a new version release planned?

@RdeWilde
Copy link

RdeWilde commented May 5, 2021

@lamasfoker thanks for the suggestion. I tried adding it, but I still get the same error. Can you provide an example on how you got it working?

@lamasfoker
Copy link

@RdeWilde you can see my solution on this file. I do not use deployphp/action but shivammathur/setup-php@master and webfactory/ssh-agent@v0.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants