Added file (--file and -f) option to deployer allowing to specify which deploy script to use

[AlexStansfield]

Issue #67

Will accept relative or absolute paths.

Example usage:
php bin/deploy --file=/home/alex/sites/deploy-scripts/wordpress.php deploy
php bin/deploy --file=deploy-scripts/anothersite.php deploy
php bin/deploy -fdeploy-scripts/wordpress.php deploy

[AlexStansfield]

Hold off on the merge, I found a bug.

[AlexStansfield]

from http://php.net/manual/en/function.realpath.php

realpath() returns FALSE on failure, e.g. if the file does not exist.

So if we've already determined the realpath call has failed it saves us from doing any other checks

[aohorodnyk]

both variants:

(is_file($file) && is_readable($file))

and

$file !== false && is_file($file) && is_readable($file)

have same behaviors, is_file and is_readable returns false if have parameter false
Your condition $var !== false is superfluous.

If you have another opinion, say please

[AlexStansfield]

Check this line:

$deployFile = realpath($optionFile);

I'm using realpath in order to create an absolute path to the file no matter if you give it a relative path (--file=scripts/site.php) or an absolute one (--file=/var/deploy/site.php).

Realpath will return false if the file does not exist (or if the function fails for any other reason).

Therefore by doing a simple check to see if $deployFile is already false I save from having to hit the filesystem again by calling is_file.

If $realpath is false already then calling is_file is superfluous and just leads to a wasted filesystem call.

I guess it's a matter of which is more wasteful, a call to the file system or a boolean comparison.

[aohorodnyk]

Thanks @AlexStansfield, I understood your opinion, it's a small optimization.
But I think will be better don't use small optimizations and have more cleared code.
Thanks, Anton

[AlexStansfield]

ok, I will remove it

[AlexStansfield]

Due to the way that Symfony\Component\Console\Input\ArgvInput works this is actually a lot harder to implement than expected.

I'm not sure if there is a nice way without creating our own Input class.

The reason being that it's pretty strict about the options and arguments passed to it. However deploy.php file itself adds options and arguments. So if I try to use the name of the stage I want to deploy to the script fails on too many arguments as it's not imported the deploy.php file yet so doesn't the stage argument hasn't been defined.

[antonmedv]

I'll will take your code to v3, and try to implement this without creation own Input class. Try to keep KISS. 👾

[AlexStansfield]

Good luck

[antonmedv]

Added in 9c37344