Skip to content

Conversation

hiqsol
Copy link
Contributor

@hiqsol hiqsol commented Dec 11, 2015

Your lib is done really nice :)
What we really miss is the ability to set Success/Fail method to POST.
Hope you'll accept this pull request.
If you're ok with the proposed code I can add tests for it.

@dercoder
Copy link
Owner

Thx.
Travic check failed but i will add your changes today

@hiqsol
Copy link
Contributor Author

hiqsol commented Dec 11, 2015

Thank you for quick answer.
I have fixed the problem with naming.

@hiqsol
Copy link
Contributor Author

hiqsol commented Dec 11, 2015

And with array declaration too.

@hiqsol
Copy link
Contributor Author

hiqsol commented Dec 11, 2015

Shall I add tests?

@hiqsol
Copy link
Contributor Author

hiqsol commented Dec 11, 2015

Added tests.

dercoder added a commit that referenced this pull request Dec 11, 2015
Added specifying of Success/Fail redirect method
@dercoder dercoder merged commit 85faeaa into dercoder:master Dec 11, 2015
@dercoder
Copy link
Owner

Thx for your pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants