[TASK] Extract getFlexFormData() to AbstractPluginPreviewRenderer

derhansen · Jul 5, 2024 · 6c6267d · 6c6267d
1 parent 58ee802
commit 6c6267d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 11 deletions.
diff --git a/Classes/Preview/AbstractPluginPreviewRenderer.php b/Classes/Preview/AbstractPluginPreviewRenderer.php
@@ -75,6 +75,18 @@ protected function getPluginName(array $record): string
         return htmlspecialchars($this->getLanguageService()->sL(self::LLPATH . 'plugin.' . $pluginId . '.title'));
     }
 
+    /**
+     * Returns the records flexform as array
+     */
+    protected function getFlexFormData(string $flexform): array
+    {
+        $flexFormData = GeneralUtility::xml2array($flexform);
+        if (!is_array($flexFormData)) {
+            $flexFormData = [];
+        }
+        return $flexFormData;
+    }
+
     /**
      * Renders the given data and action as HTML table for plugin preview
      */

diff --git a/Classes/Preview/PieventPreviewRenderer.php b/Classes/Preview/PieventPreviewRenderer.php
@@ -23,11 +23,7 @@ public function renderPageModulePreviewContent(GridColumnItem $item): string
     {
         $data = [];
         $record = $item->getRecord();
-        $flexFormData = GeneralUtility::xml2array($record['pi_flexform']);
-        if (!is_array($flexFormData)) {
-            $flexFormData = [];
-        }
-
+        $flexFormData = $this->getFlexFormData($record['pi_flexform']);
         $pluginName = $this->getPluginName($record);
 
         $this->setPluginPidConfig($data, $flexFormData, 'listPid', 'additional');

diff --git a/Classes/Preview/PiuserregPreviewRenderer.php b/Classes/Preview/PiuserregPreviewRenderer.php
@@ -12,19 +12,14 @@
 namespace DERHANSEN\SfEventMgt\Preview;
 
 use TYPO3\CMS\Backend\View\BackendLayout\Grid\GridColumnItem;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 class PiuserregPreviewRenderer extends AbstractPluginPreviewRenderer
 {
     public function renderPageModulePreviewContent(GridColumnItem $item): string
     {
         $data = [];
         $record = $item->getRecord();
-        $flexFormData = GeneralUtility::xml2array($record['pi_flexform']);
-        if (!is_array($flexFormData)) {
-            $flexFormData = [];
-        }
-
+        $flexFormData = $this->getFlexFormData($record['pi_flexform']);
         $pluginName = $this->getPluginName($record);
 
         $this->setPluginPidConfig($data, $flexFormData, 'registrationPid', 'sDEF');