Skip to content

Ahmed/dapi 774/chore update error handling app register #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Ahmed/dapi 774/chore update error handling app register #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdfb388
ahmed/DAPI-774/chore--update-error-handling-app-register
ahmed-deriv Oct 21, 2024
0bd0307
Merge remote-tracking branch 'upstream/master' into ahmed/DAPI-774/ch…
ahmed-deriv Oct 21, 2024
cf76ec7
Remove console logs
ahmed-deriv Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 0 additions & 69 deletions src/features/dashboard/components/Tabs/__tests__/tabs.test.tsx
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/features/dashboard/components/Tabs/index.ts
View file
Open in desktop

This file was deleted.

61 changes: 0 additions & 61 deletions src/features/dashboard/components/Tabs/tabs.module.scss
View file
Open in desktop

This file was deleted.

94 changes: 0 additions & 94 deletions src/features/dashboard/components/Tabs/tabs.tsx
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions ...board/components/app-register-success-modal/__tests__/app-register-success-modal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,9 @@ describe('AppRegisterSuccessModal', () => {
const configure_btn = await screen.findByText(/configure now/i);
await userEvent.click(configure_btn);
expect(mock_configure).toHaveBeenCalledTimes(1);
expect(mock_cancel).toHaveBeenCalledTimes(1);

const maybe_later_btn = await screen.findByText(/maybe later/i);
await userEvent.click(maybe_later_btn);
expect(mock_cancel).toHaveBeenCalledTimes(2);
expect(mock_cancel).toHaveBeenCalledTimes(1);
});
});
7 changes: 2 additions & 5 deletions src/features/dashboard/components/app-register-success-modal/app-register-success-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,9 @@ const AppRegisterSuccessModal = ({
<Modal
isOpened={app_register_modal_open}
primaryButtonLabel={translate({ message: 'Configure now' })}
primaryButtonCallback={() => {
onConfigure();
onCancel();
}}
primaryButtonCallback={() => onConfigure()}
secondaryButtonLabel={translate({ message: 'Maybe later' })}
secondaryButtonCallback={onCancel}
secondaryButtonCallback={() => onCancel()}
isMobile={deviceType !== 'desktop'}
showHandleBar
showSecondaryButton
Expand Down
Loading
Loading