Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding rotate to the supported css transforms #21

Closed
wants to merge 1 commit into from

Conversation

kirbysayshi
Copy link

I used isotope in a prototype, and needed to rotate the elements outside of isotope. Unfortunately, isotope overwrote my manual setting of -moz-transform: rotate(10deg) (also, not blaming isotope completely for that, because the transform property is just a single string). So I wrote a CSS hook so isotope would at least preserve the setting!

It might be nice to separate these hooks from isotope. Adding them to the global jQuery object without telling people is slightly dangerous. One solution is to use jQuery.sub() internally.

Thanks for making a stunning plugin!

@desandro
Copy link
Member

First off, this righteous commit and I thank you for that. I've opened up a separate issue 22 so we can track it.

But I'd rather not merge this commit into master. Adding another hook would mean another iteration inside the for ( fnName in data ) loop within isoTransform.set.

Using jQuery.sub - this could be a good way to resolve it. I'm going to have to investigate this further

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants