Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect test for custom layout #18

Closed
karimsa opened this issue Apr 20, 2016 · 2 comments
Closed

incorrect test for custom layout #18

karimsa opened this issue Apr 20, 2016 · 2 comments

Comments

@karimsa
Copy link
Contributor

karimsa commented Apr 20, 2016 •
edited
Loading

It is difficult to fix #17 with an incorrect test (a stream is being treated like a promise).

EDIT: I removed the log as it pertained towards a different test.

The handling of the stream is incorrect on lines 105-123.
@mlucool
Copy link
Member

mlucool commented Apr 21, 2016

Yes I agree, that does look like the incorrect usage of promises. Can you make a PR to fix?

@karimsa
Copy link
Contributor Author

karimsa commented Apr 21, 2016

Yes, I am working on it on my fork.

karimsa pushed a commit to karimsa/gulp-jsdoc3 that referenced this issue Apr 26, 2016
handle stream correctly (fix deshaw#18)
cacd555
@karimsa karimsa mentioned this issue Apr 26, 2016
Merged
mlucool added a commit that referenced this issue May 28, 2016
@mlucool
Merge pull request #20 from karimsa/master
908f356 
PR to fix #17 and #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlucool @karimsa