Don't update rss feeds every post

[psychobunny]

Maybe update it once an hour, or so. Great for really busy forums.

side effects include preventing migrators from blowing up your server

[psychobunny]

ezmode just write the last rss parse time to db and if > 3600 * 1000 update rss if not, leave it alone.

[akhoury]

+1 -
well, to be fair, if someone is migrating a huge forum, i dont think it's a big deal to actually go in and comment out few lines in NodeBB code, unless the code can have some mode, like a safe-mode, where all the fancy stuff are disabled, but that too much to ask lol.

[akhoury]

hey @psychobunny I did some testing and and I can confirm the feed and the plugins.firehook stuff were the biggest offenders,
see the Post.create commented-out line here
akhoury/nodebb-plugin-import#3

why not refactor Post.create into 2 functions, an essential part and the fancy part, and the importers can only use the essential part, I think that's an easy solution.

[barisusakli]

We were talking about the same thing today. I think Posts.create should be that internal function and Posts.reply can be the one that is called from the client. Topics.post also uses Posts.create so might have to juggle some stuff around there too.

[julianlam]

The thing that made me do a double take was that Posts.create and Posts.reply are essentially the same thing, except that Posts.reply does a little bit of extra stuff (i.e. notify followers, etc).

In the interest of DRY, we probably have Posts.reply refactored to call Posts.create, have Topics.post call Posts.reply instead

[akhoury]

+1 sweet