Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fujilupe release candidate #69

Merged
merged 114 commits into from
Jul 20, 2022
Merged

Fujilupe release candidate #69

merged 114 commits into from
Jul 20, 2022

Conversation

moustakas
Copy link
Member

@moustakas moustakas commented Jul 10, 2022

Backwards incompatible updates in preparation of generating fastspec and fastphot catalogs for Fuji+Guadalupe. Together with #55, #61, and #64, this PR contains many significant improvements, including:

Still on the critical path at the moment:

  • Profile the code to identify speed-ups.
  • Test the feasibility of writing out the best-fitting model spectra.
  • Consider gzipping the output catalogs, in order to save disk space.
  • Fix the failing unit tests.
  • Update the documentation and installation instructions.

@moustakas moustakas mentioned this pull request Jul 17, 2022
@moustakas
Copy link
Member Author

@weaverba137 @sbailey I'm having trouble understanding why coverage tests are failing. One of the errors is Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs. Could you help me debug or point me in the right direction if you've seen this before?

@moustakas
Copy link
Member Author

There's some discussion of the coverage failures here but one of the suggested solutions unfortunately didn't work--
lemurheavy/coveralls-public#1435

@moustakas moustakas added this to the fuji milestone Jul 19, 2022
@moustakas
Copy link
Member Author

These tasks are complete:

  • Test the feasibility of writing out the best-fitting model spectra.
  • Consider gzipping the output catalogs, in order to save disk space.
  • Fix the failing unit tests.

These tasks will be moved to a separate PR:

  • Profile the code to identify speed-ups.
  • Update the documentation and installation instructions.

@moustakas moustakas merged commit 229fece into main Jul 20, 2022
@moustakas moustakas deleted the fujidev-continued branch July 20, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant