Generate arm64 builds of git and git-lfs #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems we didn't even use it
sergiou87
changed the title
sergiou87
commented
Apr 28, 2021
Comment on lines
+66
to
+69
| - name: Use go ${{ matrix.go }} | ||
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: ${{ matrix.go }} |
There was a problem hiding this comment.
I needed to enforce a newer version of go (by default it used 1.15) otherwise go wouldn't be able to link git-lfs for arm64.
sergiou87
commented
Apr 28, 2021
| shell: bash | ||
| run: script/build.sh | ||
| env: | ||
| TARGET_PLATFORM: ${{ matrix.targetPlatform }} | ||
| TARGET_ARCH: ${{ matrix.arch }} | ||
| # Needed for macOS arm64 until hosted macos-11.0 runners become available | ||
| SDKROOT: /Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk |
There was a problem hiding this comment.
I made a specific job for arm64 in order to keep SDKROOT used only here, since we're specifically trying to use an older version of Xcode and the SDK for macOS x86_64 for maximum compatibility with older macOS versions (see #350).
sergiou87
commented
Apr 28, 2021
Comment on lines
-43
to
-65
| }, | ||
| "smimesign": { | ||
| "version": "0.0.6", | ||
| "files": [ | ||
| { | ||
| "platform": "darwin", | ||
| "arch": "amd64", | ||
| "name": "smimesign-0.0.6-macos.tgz", | ||
| "checksum": "771790f685176b132cb287302a9374120184f7f7973038a0232efee145781906" | ||
| }, | ||
| { | ||
| "platform": "windows", | ||
| "arch": "amd64", | ||
| "name": "smimesign-windows-amd64-0.0.6.zip", | ||
| "checksum": "2a2f946e31f2d74eadcdcd97b7bfc69298cee2f11cf7cb03c604d28fa1b34cd3" | ||
| }, | ||
| { | ||
| "platform": "windows", | ||
| "arch": "x86", | ||
| "name": "smimesign-windows-386-0.0.6.zip", | ||
| "checksum": "9a13d00aa02c0a5d277c030297d09f10a467f31e6740f1520a08e09a23046323" | ||
| } | ||
| ] |
There was a problem hiding this comment.
I realized we don't use smimesign at all, so I spent some time trying to make it build for arm64 but it's not needed.
theofficialgman
added a commit
to theofficialgman/dugite-native
that referenced
this pull request
Jul 5, 2023
Also remove go version specification as the default version is now high enough ( see desktop#354 (comment) )
theofficialgman
added a commit
to theofficialgman/dugite-native
that referenced
this pull request
Jul 5, 2023
Also remove go version specification as the default version is now high enough ( see desktop#354 (comment) )
theofficialgman
added a commit
to theofficialgman/dugite-native
that referenced
this pull request
Jul 5, 2023
Also remove go version specification as the default version is now high enough ( see desktop#354 (comment) )
theofficialgman
added a commit
to theofficialgman/dugite-native
that referenced
this pull request
Jul 5, 2023
Also remove go version specification as the default version is now high enough ( see desktop#354 (comment) )
theofficialgman
added a commit
to theofficialgman/dugite-native
that referenced
this pull request
Jul 5, 2023
Also remove go version specification as the default version is now high enough ( see desktop#354 (comment) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the build-macos script and our CI workflow to allow generating macOS builds of git and git-lfs for arm64.
In order to do that there are a couple of "hacks":
DEVELOPER_CLFAGSto "inject" our-targetcflag to specify the target architecture.go generategit-lfs/git-lfs#4492 for more details.