Crash on opening specific link #556
Comments
|
Woohoo I broke the app! So this link is a relative one (no protocol or host part as the target, only FWIW for me Jerboa opens Chrome with the link, which then obviously doesn't work because of the missing host. In general it would be nice if Jerboa (and other frontends) could just natively convert |
|
Related: #454 |
|
Nevermind, for me it crashes too with 0.0.33 from Play Store. I think it was with a previous version that those links opened in Chrome. @Anna-log7 might this be related to #413? I think the null check on |
|
At first glance that link looks formatted differently from what I tested on ( |
|
But would that community name I can't install Android Studio to debug it right now and zero experience with Jetpack Compose, but if you have a link target of only |
This is a partial fix to LemmyNet#556, but it at least prevents crashing when an unknown URL type is encountered. There is still some work to do, since the markdown plugin interprets the following as mailto: urls: - @user@instance - !community@instance I'm not sure what the supported URL types are intended to be, so I didn't bother implementing a plugin.
This is a partial fix to LemmyNet#556, but it at least prevents crashing when an unknown URL type is encountered. There is still some work to do, since the markdown plugin interprets the following as mailto: urls: - @user@instance - !community@instance I'm not sure what the supported URL types are intended to be, so I didn't bother implementing a plugin.
twizmwazin
added
bug
This is a partial fix to LemmyNet#556, but it at least prevents crashing when an unknown URL type is encountered. There is still some work to do, since the markdown plugin doesn't properly interpret URLs the way we want. User-related parsing still doesn't work because there's work needed in the markdown layer, but once that's done, this should just work as intended.
This is a partial fix to LemmyNet#556, but it at least prevents crashing when an unknown URL type is encountered. There is still some work to do, since the markdown plugin doesn't properly interpret URLs the way we want. User-related parsing still doesn't work because there's work needed in the markdown layer, but once that's done, this should just work as intended.
This is a partial fix to LemmyNet#556, but it at least prevents crashing when an unknown URL type is encountered. There is still some work to do, since the markdown plugin doesn't properly interpret URLs the way we want. User-related parsing still doesn't work because there's work needed in the markdown layer, but once that's done, this should just work as intended.
This is a partial fix to LemmyNet#556, but it at least prevents crashing when an unknown URL type is encountered. There is still some work to do, since the markdown plugin doesn't properly interpret URLs the way we want. User-related parsing still doesn't work because there's work needed in the markdown layer, but once that's done, this should just work as intended.
This is a partial fix to LemmyNet#556, but it at least prevents crashing when an unknown URL type is encountered. There is still some work to do, since the markdown plugin doesn't properly interpret URLs the way we want. User-related parsing still doesn't work because there's work needed in the markdown layer, but once that's done, this should just work as intended.
This is a partial fix to LemmyNet#556, but it at least prevents crashing when an unknown URL type is encountered. There is still some work to do, since the markdown plugin doesn't properly interpret URLs the way we want. User-related parsing still doesn't work because there's work needed in the markdown layer, but once that's done, this should just work as intended.
This is a partial fix to LemmyNet#556, but it at least prevents crashing when an unknown URL type is encountered. There is still some work to do, since the markdown plugin doesn't properly interpret URLs the way we want. User-related parsing still doesn't work because there's work needed in the markdown layer, but once that's done, this should just work as intended.
This is a partial fix to LemmyNet#556, but it at least prevents crashing when an unknown URL type is encountered. There is still some work to do, since the markdown plugin doesn't properly interpret URLs the way we want. User-related parsing still doesn't work because there's work needed in the markdown layer, but once that's done, this should just work as intended.
* Handle more URL types This is a partial fix to #556, but it at least prevents crashing when an unknown URL type is encountered. There is still some work to do, since the markdown plugin doesn't properly interpret URLs the way we want. User-related parsing still doesn't work because there's work needed in the markdown layer, but once that's done, this should just work as intended. * Support http links
* Handle more URL types This is a partial fix to LemmyNet#556, but it at least prevents crashing when an unknown URL type is encountered. There is still some work to do, since the markdown plugin doesn't properly interpret URLs the way we want. User-related parsing still doesn't work because there's work needed in the markdown layer, but once that's done, this should just work as intended. * Support http links
|
Ok, this should behave a lot better now, please retest. |
|
Given the lack of updated info and the number of changes that have happened surrounding link handling, I'm going to mark this one as complete. |
** Jerboa Version **
0.0.33
Describe the bug
In this post to c/Anime@lemmy.ml : https://feddit.de/post/761086 , clicking on the markdown-styled link in the first paragraph to c/japanesemusic@feddit.de crashes the app.
I haven't seen any other links that also do this, but I will update if I find anything.
To Reproduce
Steps to reproduce the behavior:
Using:
The text was updated successfully, but these errors were encountered: