Bump Serilog to 3.1.1 #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tests
sungam3r
commented
Jan 20, 2024
| @@ -1,6 +1,6 @@ | |||
| namespace Destructurama | |||
| { | |||
| public static class LoggerConfigurationAppSettingsExtensions | |||
| public static class LoggerConfigurationJsonNetExtensions | |||
There was a problem hiding this comment.
@nblumhardt I think this class was initially copied from other project. I rename it in light of major version bump. OK?
sungam3r
commented
Jan 20, 2024
| @@ -1,15 +1,15 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>net452;netstandard2.0</TargetFrameworks> | |||
| <TargetFrameworks>net462;netstandard2.0</TargetFrameworks> | |||
There was a problem hiding this comment.
@nblumhardt Keep net462 or drop?
There was a problem hiding this comment.
I think there's value in 462, I'd also consider adding net6.0; no strong feelings though
There was a problem hiding this comment.
I'll publish net462;netstandard2.0 in v3. We can add net6 later if some issue arises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.