Skip to content

Commit

Permalink
fix: change external_run_id to string type in FlatRun proto (#9744)
Browse files Browse the repository at this point in the history
(cherry picked from commit 2cdfdf9)
  • Loading branch information
AmanuelAaron authored and determined-ci committed Jul 29, 2024
1 parent 8ef93f8 commit e345871
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions harness/determined/common/api/bindings.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified proto/buf.image.bin
Binary file not shown.
8 changes: 4 additions & 4 deletions proto/pkg/runv1/run.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion proto/src/determined/run/v1/run.proto
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ message FlatRun {
// Signed searcher metrics value.
optional double searcher_metric_value = 8;
// The id of external run
optional int32 external_run_id = 9;
optional string external_run_id = 9;
// Trial hyperparameters.
optional google.protobuf.Struct hyperparameters = 10;
// summary metrics.
Expand Down
4 changes: 2 additions & 2 deletions webui/react/src/services/api-ts-sdk/api.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion webui/react/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1279,7 +1279,7 @@ export interface FlatRun {
checkpointSize: number;
checkpointCount: number;
searcherMetricValue?: number;
externalRunId?: number;
externalRunId?: string;
hyperparameters?: TrialHyperparameters;
summaryMetrics?: SummaryMetrics;
userId?: number;
Expand Down

0 comments on commit e345871

Please sign in to comment.