Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clean up resource pool docs and add release notes #1917

Conversation

armandmcqueen
Copy link
Contributor

Description

Improve resource pool docs and add release notes for the resource pool feature.

Test Plan

Commentary (optional)

Checklist

  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.

docs/topic-guides/system-concepts/resource-pool.txt Outdated Show resolved Hide resolved
docs/topic-guides/system-concepts/resource-pool.txt Outdated Show resolved Hide resolved
docs/topic-guides/system-concepts/resource-pool.txt Outdated Show resolved Hide resolved
``resource_pools``. The ``resource_manager`` section is for cluster
format has changed to a new format.

This is a backwards compatible change and cluster configurations in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: do we have a migration guide for this change?

process of moving around and renaming a small number of top-level
fields.

The old format had the top level fields of ``scheduler`` and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonblocking: probably should make it a separate section migration guide in the cluster configuration reference not in a topic guide and link it in the release note.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a good idea. If you have time to get it into this release, that would be great. Otherwise we can do that for the next release.

@shiyuann shiyuann assigned armandmcqueen and unassigned shiyuann Feb 3, 2021
armandmcqueen and others added 3 commits February 3, 2021 13:31
Co-authored-by: Shiyuan <shiyuan@determined.ai>
Co-authored-by: Shiyuan <shiyuan@determined.ai>
Co-authored-by: Shiyuan <shiyuan@determined.ai>
@shiyuann shiyuann assigned armandmcqueen and unassigned shiyuann Feb 3, 2021
@armandmcqueen armandmcqueen merged commit 9e0be99 into determined-ai:master Feb 3, 2021
determined-dsw pushed a commit that referenced this pull request Feb 4, 2021
Improve resource pool docs and add release notes for the resource pool feature.

(cherry picked from commit 9e0be99)
@dannysauer dannysauer added this to the 0.14.2 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants