Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add state to task endpoints [DET-4987] #1958

Merged
merged 6 commits into from
Feb 17, 2021
Merged

fix: add state to task endpoints [DET-4987] #1958

merged 6 commits into from
Feb 17, 2021

Conversation

hamidzr
Copy link
Member

@hamidzr hamidzr commented Feb 11, 2021 •
edited
Loading

Description

  • update tasks api to return a top-level state
  • share the logic with the old endpoint

Test Plan

Commentary (optional)

Checklist

  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • add the remaining commands, shells, and tensorboards

@cla-bot cla-bot bot added the cla-signed label Feb 11, 2021
@hamidzr hamidzr changed the title add state to tasks fix: add state to task endpoints [DET-4987] Feb 11, 2021
@hamidzr hamidzr requested a review from stoksc February 11, 2021 20:42
stoksc
stoksc reviewed Feb 12, 2021
View reviewed changes
Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just had some questions

proto/src/determined/api/v1/task.proto Show resolved Hide resolved
master/internal/command/command.go Outdated Show resolved Hide resolved
stoksc
stoksc approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

proto/src/determined/task/v1/task.proto Outdated Show resolved Hide resolved
proto/src/determined/task/v1/task.proto Outdated Show resolved Hide resolved
proto/src/determined/task/v1/task.proto Outdated Show resolved Hide resolved
master/internal/command/state.go Outdated Show resolved Hide resolved
@stoksc stoksc assigned hamidzr and unassigned stoksc Feb 16, 2021
@hamidzr hamidzr enabled auto-merge (squash) February 17, 2021 01:01
@hamidzr hamidzr merged commit 8e33f2a into determined-ai:master Feb 17, 2021
@snyk-bot snyk-bot mentioned this pull request Jan 13, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 10, 2022
Open
@dannysauer dannysauer mentioned this pull request Nov 3, 2022
Open
@dannysauer dannysauer added this to the 0.14.2 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoksc stoksc stoksc approved these changes

Assignees

@hamidzr hamidzr

Labels
cla-signed
Projects
None yet
Milestone
0.14.2
Development

Successfully merging this pull request may close these issues.
3 participants
@hamidzr @stoksc @dannysauer