fix: detect parcoords filter removal properly #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamidzr
approved these changes
Mar 2, 2021
| }); | ||
| } | ||
| setConstraints(prev => { | ||
| const newConstraints = clone(prev); |
There was a problem hiding this comment.
nit: can we tell clone (generic type) what type we expect at the end so `new constraints doesn't turn into any?
There was a problem hiding this comment.
unfortunately this is going to blow to a pretty big change. This deserves it's own tech debt ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HP Parallel Coordinates filters that are previously removed come back during a re-render. Update the chart to detect filter removal and properly save the removal state.
Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.