refactor: combine common, cli, deploy into one python package [DET-4756] #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioga
force-pushed
the
combine
branch
2 times, most recently
from
a2e2bbd
to
3c9ebff
Compare
| ], | ||
| entry_points={"console_scripts": ["det-deploy = determined_deploy.__main__:main"]}, |
There was a problem hiding this comment.
I also think that the det-deploy executable belongs to the determined_deploy package, and that the main repo should only contain det deploy
There was a problem hiding this comment.
I was thinking of det deploy as a separate chunk of work, for a later, separate PR. Then keeping det-deploy in determined_deploy defeats the whole purpose of merging it into the main package.
We can keep both det-deploy and det deploy in the main package to ease the migration, print a deprecation in det-deploy, and then eventually remove it.
rb-determined-ai
approved these changes
Mar 23, 2021
ioga
added a commit
to ioga/determined
that referenced
this pull request
Apr 7, 2021
- reapply some work from determined-ai#2108 that was reverted in determined-ai#2153 and determined-ai#2156. - add more docs.
3 tasks
ioga
added a commit
that referenced
this pull request
Apr 12, 2021
philipnrmn
added a commit
to philipnrmn/determined
that referenced
this pull request
Dec 4, 2021
Tests were moved from ./cli to ./harness in determined-ai#2108 but the make target was not updated. Here we remove it so that the absence of the tests directory does not cause `make test` to fail.
3 tasks
philipnrmn
added a commit
that referenced
this pull request
Dec 4, 2021
* fix: remove test-cli from make test Tests were moved from ./cli to ./harness in #2108 but the make target was not updated. Here we remove it so that the absence of the tests directory does not cause `make test` to fail. * fix: remove test-common from make test Tests were moved from ./common to ./harness in #2018 but the make target was not updated. Here we remove it so that the absence of the tests directory does not cause `make test` to fail.
hkang1
pushed a commit
to hkang1/determined
that referenced
this pull request
Feb 2, 2022
* fix: remove test-cli from make test Tests were moved from ./cli to ./harness in determined-ai#2108 but the make target was not updated. Here we remove it so that the absence of the tests directory does not cause `make test` to fail. * fix: remove test-common from make test Tests were moved from ./common to ./harness in determined-ai#2018 but the make target was not updated. Here we remove it so that the absence of the tests directory does not cause `make test` to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
determined-common,determined-cli,determined-deploypython packages are now DEPRECATED as they've been combined intodeterminedpackage.harness/determined/<OLD_PACKAGE_NAME>determined_{common,deploy,cli}todetermined.{common,deploy,cli}Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.