Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "Testing gang-scheduling [DET-5134]" #2110

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

mackrorysd
Copy link
Member

This reverts commit 2c5beaa.

Description

This failed a GKE run and needs investigation. It also failed the normal GPU tests because it's missing the TOTAL_SLOTS setting.

Test Plan

I'll fix the TOTAL_SLOTS problem on the GPU tests, and repush this to an upstream branch to troubleshoot the other failure. Reverting now to unblock tests.

@cla-bot cla-bot bot added the cla-signed label Mar 21, 2021
@mackrorysd mackrorysd changed the title Revert "Testing gang-scheduling [DET-5134] (#2100)" chore: Revert "Testing gang-scheduling [DET-5134]" Mar 21, 2021
Copy link
Contributor

@eecsliu eecsliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm interesting issue

@mackrorysd mackrorysd merged commit 60ab3d3 into determined-ai:master Mar 21, 2021
@dannysauer dannysauer added this to the 0.14.6 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants