chore: change output format of JSON aggregated resource data #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoksc
reviewed
Mar 26, 2021
| @@ -1,25 +1,63 @@ | |||
| WITH const AS ( | |||
| SELECT | |||
| daterange($1 :: date, $2 :: date, '[]') AS period | |||
| ), | |||
| months AS ( | |||
There was a problem hiding this comment.
after reading a few times, with some parameters, seems this query can produce the other. i don't think it's a big enough deal to change though.
stoksc
approved these changes
Mar 26, 2021
| // One instance of slots in the cluster being allocated to a task during a day | ||
| // (aggregated). | ||
| // One instance of slots in the cluster being allocated to a task during a | ||
| // period (aggregated). | ||
| message ResourceAllocationAggregatedEntry { |
There was a problem hiding this comment.
Took me a second to grok this API, probably a lot better for a user I agree, but dang is it a lot funkier on the backend. Immediately think of https://en.wikipedia.org/wiki/Object%E2%80%93relational_impedance_mismatch.
There was a problem hiding this comment.
Heh, yeah; I hadn't heard that term, but that's basically exactly how I felt. I tell myself it's our job to do the funky stuff so everything comes out nice.
Update the structure of the JSON returned for the aggregated endpoint to match the ERD. Rather than a separate entry for each aggregation key, we have one entry per period with maps containing the individual subentries. The CSV output remains the same, since we don't really want to express structured data like that in CSV.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains #2123; look at the last commit of this PR only.
Description
Update the structure of the JSON returned for the aggregated endpoint to
match the ERD. Rather than a separate entry for each aggregation key, we
have one entry per period with maps containing the individual
subentries.
The CSV output remains the same, since we don't really want to express
structured data like that in CSV.
Test Plan
det res aggwith all combinations of--monthlyand--json, eyeball results