Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: det deploy check for sufficient gpu quotas on aws, gcp [DET-5156] #2136

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

ioga
Copy link
Contributor

@ioga ioga commented Mar 29, 2021

Description

  • det deploy check for sufficient gpu quotas on aws, gcp.
  • det deploy local check for installed / functioning docker.
  • run --no-gpu for darwin by default.

Test Plan

Commentary (optional)

Checklist

  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.

@cla-bot cla-bot bot added the cla-signed label Mar 29, 2021
@ioga ioga marked this pull request as ready for review March 29, 2021 22:46
@ioga ioga requested a review from shiyuann as a code owner March 29, 2021 22:46
@ioga ioga requested review from hoanghphan and dzhu March 29, 2021 22:46
@dzhu dzhu self-assigned this Mar 30, 2021
harness/determined/deploy/errors.py Outdated Show resolved Hide resolved
harness/determined/common/declarative_argparse.py Outdated Show resolved Hide resolved
harness/determined/deploy/aws/preflight.py Outdated Show resolved Hide resolved
harness/determined/deploy/aws/preflight.py Outdated Show resolved Hide resolved
harness/determined/deploy/aws/preflight.py Outdated Show resolved Hide resolved
harness/determined/deploy/aws/preflight.py Outdated Show resolved Hide resolved
harness/determined/deploy/aws/preflight.py Outdated Show resolved Hide resolved
harness/determined/deploy/gcp/preflight.py Outdated Show resolved Hide resolved
harness/determined/deploy/gcp/preflight.py Outdated Show resolved Hide resolved
@dzhu dzhu assigned ioga and unassigned dzhu Mar 31, 2021
@ioga ioga assigned dzhu and unassigned ioga Mar 31, 2021
Copy link
Contributor

@dzhu dzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! det deploy can really use the attention.

harness/determined/deploy/aws/gen_vcpu_mapping.py Outdated Show resolved Hide resolved
harness/determined/deploy/errors.py Outdated Show resolved Hide resolved
harness/determined/deploy/gcp/preflight.py Outdated Show resolved Hide resolved
harness/determined/deploy/local/preflight.py Outdated Show resolved Hide resolved
@dzhu dzhu assigned ioga and unassigned dzhu Apr 2, 2021
 - check gpu quotas on aws, gcp
 - check docker for local cluster deployments
 - also disable gpu on darwin by default for local clusters
@ioga ioga changed the title feat: det deploy check for sufficient gpu quotas on aws, gcp. feat: det deploy check for sufficient gpu quotas on aws, gcp [DET-5156] Apr 2, 2021
@ioga ioga enabled auto-merge (squash) April 2, 2021 19:08
@ioga ioga merged commit 14e9911 into determined-ai:master Apr 2, 2021
@dannysauer dannysauer added this to the 0.15.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants