feat: async DELETE experiment [DET-5804] #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for determined-ui ready! 🔨 Explore the source changes: d9df59d 🔍 Inspect the deploy log: https://app.netlify.com/sites/determined-ui/deploys/60f8345c206771000703945c 😎 Browse the preview: https://deploy-preview-2741--determined-ui.netlify.app/ |
stoksc
commented
Jul 16, 2021
master/static/migrations/20210716133048_add-deleting-states.down.sql
Outdated
Show resolved
Hide resolved
stoksc
commented
Jul 16, 2021
master/static/migrations/20210716133048_add-deleting-states.up.sql
Outdated
Show resolved
Hide resolved
hamidzr
reviewed
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the
DELETINGandDELETE_FAILEDstates to experiments and changesDELETE /api/v1/experiments/<id>to work asynchronously. Now upon aDELETE, after all validation happens, the experiment is moved to theDELETINGstate and the deletion takes place asynchronously. If it fails, the experiment is moved to theDELETE_FAILEDstate. Also on master restart, allDELETINGexperiments are moved toDELETE_FAILED.DELETE_FAILEDcan be retried manually by the user, but it not retried automatically since it would likely fail if it failed recently.Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.