refactor: authz provider implementation and authz users basic implementation #4676
Conversation
✅ Deploy Preview for determined-ui canceled.
|
| } | ||
| return nil, errors.Wrap(grpcutil.ErrPermissionDenied, err.Error()) | ||
| } | ||
|
|
There was a problem hiding this comment.
no check for if the user can patch other users?
There was a problem hiding this comment.
PatchUser in grpc I think only allows for setting a users display name currently
The check for setting other use display names is in CanSetUsersDisplayName I think?
| return | ||
| } | ||
|
|
||
| knownAuthZTypes = make(map[string]bool) |
There was a problem hiding this comment.
It seems like knownAuthZTypes can be remade if this is called more than once? Should be locked down with a once like in the provider
There was a problem hiding this comment.
There is a nil check for knownAuthZTypes above -- which I missed for like a couple minutes wondering how it even worked lol
|
Is this dependent on Ilia's authz work? Would you want to merge this into |
Ilia's authz work is already in this PR and I think I would rather to keep commit history cleaner keeping this change separate? Also I think I changed my mind about |
Description
Refactor the user api both echo and grpc to use the new
authzpattern.Test Plan
existing e2e tests + new integration tests
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
/webui/react/src/shared/verifymake -C webui/react test-sharedpasses.