Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: react-router-dom partial update part1 #4788

Merged
merged 3 commits into from
Aug 16, 2022
Merged

chore: react-router-dom partial update part1 #4788

merged 3 commits into from
Aug 16, 2022

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Aug 15, 2022 •
edited by jira bot
Loading

Description

Successor of #4619

Followed the instruction

I'm done with props.match -> v6 useParams in 2) Change component code use v6 instead of v5 APIs

Test Plan

  • Check if all routes work

Commentary (optional)

Checklist

  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.
  • If modifying /webui/react/src/shared/ verify make -C webui/react test-shared passes.

@cla-bot cla-bot bot added the cla-signed label Aug 15, 2022
@netlify
Copy link

netlify bot commented Aug 15, 2022 •
edited
Loading

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 07552db
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/62fac2cb7739b0000845ca48
😎 Deploy Preview https://deploy-preview-4788--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@keita-determined keita-determined changed the title Chore/react router dom update chore: react router dom partial update Aug 15, 2022
@keita-determined keita-determined changed the title chore: react router dom partial update chore: react-router-dom partial update Aug 15, 2022
@keita-determined keita-determined changed the title chore: react-router-dom partial update chore: react-router-dom partial update part1 Aug 16, 2022
trentwatt
trentwatt approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@trentwatt trentwatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keita-determined keita-determined merged commit 3191b4c into determined-ai:master Aug 16, 2022
@keita-determined keita-determined deleted the chore/react-router-dom-update branch August 16, 2022 18:38
@keita-determined keita-determined mentioned this pull request Aug 16, 2022
Closed
4 tasks
NicholasBlaskey pushed a commit to NicholasBlaskey/determined that referenced this pull request Aug 24, 2022
@keita-determined @NicholasBlaskey
chore: react-router-dom partial update part1 (determined-ai#4788)
a129ebd 
* chore: setup router compatibility package

* chore: RR v5 props.match -> v6 useParams

* fix: props order
@keita-determined keita-determined mentioned this pull request Sep 28, 2022
Merged
5 tasks
@dannysauer dannysauer modified the milestones: 0.0.102, 0.19.2 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentwatt trentwatt trentwatt approved these changes

Assignees

@trentwatt trentwatt

Labels
cla-signed
Projects
None yet
Milestone
0.19.2
Development

Successfully merging this pull request may close these issues.
3 participants
@keita-determined @trentwatt @dannysauer