-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: resource pool support for PBS #4884
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for storybook-det ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
phillip-gaisford
changed the title
chore: resource pool constants for PBS
chore: resource pool support for PBS
Aug 30, 2022
lgtm though let me add someone from web |
stoksc
requested review from
keita-determined
and removed request for
trentwatt
August 30, 2022 18:48
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a member from web
stoksc
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add some resource pool constants to describe PBS as the underlying workload manager on the HPC cluster, then update the WebUI to handle PBS.
Also, update unsupportedQPosSchedulers, as per Bradley.
Test Plan
Tested manually on the horizon & casablanca clusters, with Slurm & PBS.
Horizon (Slurm):
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
/webui/react/src/shared/
verifymake -C webui/react test-shared
passes.