Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resource pool support for PBS #4884

Merged
merged 5 commits into from
Aug 30, 2022
Merged

chore: resource pool support for PBS #4884

merged 5 commits into from
Aug 30, 2022

Conversation

phillip-gaisford
Copy link
Contributor

@phillip-gaisford phillip-gaisford commented Aug 26, 2022

Description

Add some resource pool constants to describe PBS as the underlying workload manager on the HPC cluster, then update the WebUI to handle PBS.

Also, update unsupportedQPosSchedulers, as per Bradley.

Test Plan

Tested manually on the horizon & casablanca clusters, with Slurm & PBS.
Screen Shot 2022-08-30 at 12 16 47 PM

Horizon (Slurm):

Screen Shot 2022-08-30 at 1 09 00 PM

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.
  • If modifying /webui/react/src/shared/ verify make -C webui/react test-shared passes.

@netlify
Copy link

netlify bot commented Aug 26, 2022

Deploy Preview for storybook-det ready!

Name Link
🔨 Latest commit e3532a2
🔍 Latest deploy log https://app.netlify.com/sites/storybook-det/deploys/630e3cca3b59b0000a494aee
😎 Deploy Preview https://deploy-preview-4884--storybook-det.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 26, 2022

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit e3532a2
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/630e3cca91d70b000a9d219f
😎 Deploy Preview https://deploy-preview-4884--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@phillip-gaisford phillip-gaisford changed the title chore: resource pool constants for PBS chore: resource pool support for PBS Aug 30, 2022
@stoksc
Copy link
Contributor

stoksc commented Aug 30, 2022

lgtm though let me add someone from web

@stoksc stoksc requested a review from trentwatt August 30, 2022 18:48
@stoksc stoksc requested review from keita-determined and removed request for trentwatt August 30, 2022 18:48
@stoksc stoksc assigned keita-determined and unassigned trentwatt Aug 30, 2022
Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a member from web

@stoksc stoksc merged commit 0306d66 into determined-ai:master Aug 30, 2022
@phillip-gaisford phillip-gaisford deleted the FOUNDENG-125 branch August 30, 2022 19:45
@dannysauer dannysauer modified the milestones: 0.0.102, 0.19.3 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants