fix: associate allocation sessions with users #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for storybook-det canceled.
|
✅ Deploy Preview for determined-ui canceled.
|
NicholasBlaskey
changed the title
NicholasBlaskey
changed the title
NicholasBlaskey
force-pushed
the
allocation_sessions_have_users
branch
from
66f4fc2
to
84ed1f5
Compare
ioga
approved these changes
Sep 6, 2022
thiagodallacqua-hpe
pushed a commit
to thiagodallacqua-hpe/determined
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4905 assumed that using user session would be ok. I wasn't considering user sessions expiring to be an issue so switched back to using allocation sessions. This change associates allocation sessions with users so that they can use
grpcutil.GetUserwhich is needed for RBAC to determined access for users.Test Plan
Run an experiment and see no errors.
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
/webui/react/src/shared/verifymake -C webui/react test-sharedpasses.