fix: avoid pip executable when upgrading pip in circleci #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
✅ Deploy Preview for storybook-det canceled.
|
drh-determined-ai
changed the title
drh-determined-ai
changed the title
drh-determined-ai
force-pushed
the
drh/circleci-pip-bugfix
branch
from
80c3385
to
e580018
Compare
drh-determined-ai
force-pushed
the
drh/circleci-pip-bugfix
branch
from
e580018
to
605c5df
Compare
drh-determined-ai
changed the title
rb-determined-ai
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
If you are not sure what precisely causes only this pip call to fail (and only fail in the windows runner) I'd recommend a comment explaining which conditions require python -m pip "for reasons which are unclear" or something to that effect.
Otherwise it looks real weird to the next developer who goes and reads this code carefully.
I wouldn't probably waste more than 20 minutes trying to figure out why fixing only this line fixes the test, if you decide to go that route.
|
In the future, maybe try to split unrelated cosmetic fixes out from technical fixes; that mixing stuff up makes tracking down "what changed" harder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: avoid pip executable when upgrading pip in circleci
Test Plan
CircleCI tests should succeed.
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
/webui/react/src/shared/verifymake -C webui/react test-sharedpasses.