fix: upload helm chart to GitHub release artifacts [INFENG-93]

[asnelling]

Description

INFENG-93

Test Plan

I haven't found a good way to test without sweeping changes to the CI config. Will try to come up with something doable.

Commentary (optional)

Checklist

• Changes have been manually QA'd
• User-facing API changes need the "User-facing API Change" label.
• Release notes should be added as a separate file under docs/release-notes/.
  See Release Note for details.
• Licenses should be included for new code which was copied and/or modified from any external code.
• If modifying /webui/react/src/shared/ verify make -C webui/react test-shared passes.

Title

fix: upload helm chart to GitHub release artifacts

[netlify]

✅ Deploy Preview for determined-ui ready!

Name	Link
🔨 Latest commit	75c8ff6
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/632b07c8ace5b00008ab2bbc
😎 Deploy Preview	https://deploy-preview-5064--determined-ui.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for storybook-det ready!

Name	Link
🔨 Latest commit	75c8ff6
🔍 Latest deploy log	https://app.netlify.com/sites/storybook-det/deploys/632b07c8817c1800092a11b8
😎 Deploy Preview	https://deploy-preview-5064--storybook-det.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[asnelling]

For testing, I had to:

1. Create a separate repo
2. In ./.circleci/config.yml:
   • comment out the login-helm step under the publish-helm job
   • comment out all workflows except for release
3. put a tag name in ./VERSION
4. comment out in ./helm/Makefile under the release target:
   • helm repo add ...
   • helm cm-push ...
5. set GITHUB_TOKEN environment variable in CircleCI
6. Create a release tag, e.g. 0.19.4
7. push above changes and tag to the separate repo

[dannysauer]

For testing, I had to:

What were the results of this test? :)

[asnelling]

The test run created this release with linked helm chart:
https://github.com/asnelling/determined/releases/tag/0.19.3-helm9

Here's the full set of changes for the test:
https://github.com/asnelling/determined/compare/master..0.19.3-helm9

[dannysauer]

LGTM

[dannysauer]

I think I would've liked to make another symlink and install goreleaser in the makefile so the process would work outside of CircleCI, but this works. So maybe call it tech debt for later. 🤷‍♂️

[asnelling]

If we didn't already use goreleaser, I would've just:

• curl .../tags/$TAG/release_id # get release id
• curl -XPOST ../releases # create new release if needed
• curl -XPOST .../$RELEASE_ID/artifacts, # upload

[asnelling]

It worked... but it published a release (with helm chart) for 0.19.4-rc0. Started a fix in https://github.com/asnelling/determined/commits/helm-release-gh
Current status with testing:

release test: no -rc# suffix

• publish-helm-gh runs
• https://app.circleci.com/pipelines/github/asnelling/determined/53/workflows/8a95e11f-8a9e-4a97-b83e-fb60db1a0401
• Just need to fix up the syntax here and that should do it:
  https://github.com/asnelling/determined/blob/cb59496d7712c8e77015ec213386f942898d4df9/helm/Makefile#L34

rc test: with -rc# suffix

• publish-helm-gh is not scheduled
• https://app.circleci.com/pipelines/github/asnelling/determined/49/workflows/3f93156b-8f88-4682-9315-346fe6a5dd51