-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow sort of metrics under avg_metrics [DET-8408] #5086
Conversation
✅ Deploy Preview for storybook-det ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
good catch. we need an automated test for this.
why is |
Have all past and future recorded metrics been converted to metrics->avg_metrics->>key ? |
database representation of these hasn't changed, it's all in training/validation CTEs in the queries. |
@ioga - OK that works. Added a client-side fix for the remaining issue |
Description
Experiment page's Workloads table was having trouble sorting by metric. Discovered this was due to metrics being wrapped inside of metrics->avg_metrics since #4746 . This change attempts to sort by metrics->>key and metrics->avg_metrics->>key. For some reason I also had to cast this to a numeric type to sort by value.
Test Plan
https://determinedai.atlassian.net/browse/DET-8408 describes an experiment which generates metrics and is always sorted server-side by batch number, which then confusingly gets sorted client-side.
Checklist
docs/release-notes/
.See Release Note for details.
/webui/react/src/shared/
verifymake -C webui/react test-shared
passes.