Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No Permissions page vs. 404 page #5088

Merged
merged 2 commits into from
Sep 23, 2022
Merged

fix: No Permissions page vs. 404 page #5088

merged 2 commits into from
Sep 23, 2022

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Sep 21, 2022

Description

When I added a 404 page in #5045 , I accidentally blocked the NoPermissions page from showing up in that case. This moves the NoPermissions check to happen first. Should not block release.

Test Plan

Remove initial permissions ( oss_user ) from contexts/Store.tsx

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.
  • If modifying /webui/react/src/shared/ verify make -C webui/react test-shared passes.

@netlify
Copy link

netlify bot commented Sep 21, 2022

Deploy Preview for storybook-det ready!

Name Link
🔨 Latest commit d588a52
🔍 Latest deploy log https://app.netlify.com/sites/storybook-det/deploys/632de37142738b0008ef63f1
😎 Deploy Preview https://deploy-preview-5088--storybook-det.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 21, 2022

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit d588a52
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/632de371de0edd000989b306
😎 Deploy Preview https://deploy-preview-5088--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mapmeld mapmeld enabled auto-merge (squash) September 23, 2022 16:48
@mapmeld mapmeld merged commit f6faa57 into determined-ai:master Sep 23, 2022
@dannysauer dannysauer modified the milestones: 0.0.102, 0.19.5 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants