fix: use theme var in Avatar stylesheet (DET-8237) #5109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
johnkim-det
changed the title
✅ Deploy Preview for storybook-det ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
johnkim-det
force-pushed
the
DET-8237a
branch
from
0858769
to
2ad2c1b
Compare
|
tests failing on https://determinedai.atlassian.net/browse/DET-8462 the story for this comp https://deploy-preview-5109--storybook-det.netlify.app/?path=/story/shared-avatar--default&args=noColor:true |
johnkim-det
changed the title
hmm you should not see the exact issue that that ticket solved. this one looks like a timeout? the ci has been really slow this week maybe retry and we'll look more into it if it persists |
hamidzr
approved these changes
Sep 27, 2022
hamidzr
added a commit
to hamidzr/determined
that referenced
this pull request
Oct 6, 2022
…d-ai#5109)" This reverts commit 21e29b8.
hamidzr
added a commit
that referenced
this pull request
Oct 6, 2022
hamidzr
added a commit
that referenced
this pull request
Oct 7, 2022
hamidzr
added a commit
that referenced
this pull request
Oct 7, 2022
dzhu
pushed a commit
that referenced
this pull request
Oct 7, 2022
keita-determined
pushed a commit
that referenced
this pull request
Oct 13, 2022
keita-determined
pushed a commit
that referenced
this pull request
Oct 13, 2022
keita-determined
added a commit
that referenced
this pull request
Oct 13, 2022
0e135bb Add webhooks icon (#21) a6df376 chore: update to `React18` (#5226) 74fb337 chore: update to `react-router-dom` v6 (#5222) b4d068d chore: new react-router components (#5166) 342fcd1 chore: revert "fix: use theme var in Avatar stylesheet [DET-8237] (#5109)" (#5211) 7968839 fix: streaming errors not being handled (#5171) 702df2e fix: use theme var in Avatar stylesheet [DET-8237] (#5109) 50953f0 fix: adjust elevation for dark mode (#5147) 7c51964 feat: Add "Members" view to workspace page [DET-8219] (#5113) 174b6a2 chore: move polling hook to shared (#5078) 1b5692e chore: reuse created loggers (#5077) c89edb0 fix: fix unshared dependency [DET-8462] (#5118) edf65a7 fix: remove `as any` (#5089) d109f87 refactor: improve storybook [DET-8099] (#5011) f52d14e chore: format code (#5058) b63e05d feat: setup `Prettier` (#5033) 6eccd09 chore: add `.prettierrc.js` (#5034) 7ceb0c4 fix: update shell and star icons (#5019) 891b55e chore: split out ui store and its actions [DET-8218] 8fd18e9 fix: update icon codes (#5002) 85bc251 feat: Add no permissions warning page[DET-8227] (#4950) 9190457 chore: recursively unwrap caught exceptions for type checks (#4966) b353798 feat: add batch register and deletion of checkpoints from experiment [DET-8130] (#4931) 80d1907 feat: adjust scrollbar color by theme (#4964) 5fe91af chore: ensure isAuthError can see into wrapped exceptions (#4934) 3c1ce8f chore: replace `PropsWithChildren` with explicit children (#4890) a938a31 feat: add disabled prop to ActionDropdown (DET-7937) (#4867) be53590 chore: add controllable logging support [DET-8025] (#4826) ee695bb chore: preserve failed action's error message (#4822) f1f1873 fix: enable moving jobs around w/o assuming the full set [DET-8015] (#4766) 587df61 build: set shared web to use xlarge resource class (#4824) 0248116 chore: share copy to clipboard btn (#4799) 937d382 style: update number input error style for dark mode (#4772) f98eee3 fix: remove core external dependency from shared (#4782) 52653ab feat: view code UI (#4473) 2e5bf53 chore: update shared tester git url format (#4773) 731d6d6 test: add tests for utils/service (#4749) ccf8086 chore: expose Avatar props through AvatarCard (#4765) 4c7d49f chore: [Ant Design] replace old menu with new menu (#4741) 58941e7 fix: fix an issue with forbidden api actions causing logout (#4737) faaf9d1 fix: hardcode pathname instead of using `paths` (#4740) 18b8ecc test: test cases for `shared/utils/routes.ts` [DET-7902] (#4706) 25302c8 chore: share sort utilities [DET-7970] (#4711) 5920e4a fix: breadcrumb text color (#4720) 867f42c fix: resolve issues around `InlineEditor` [DET-7914] (#4713) b509341 feat: One-Click Hyperparameter Search [DET-7537] [DET-7538] (#4458) e3e926b fix: fix low contrast issue for button styles [DET-7958] (#4692) 59d7147 fix: mark all 4xx api failures as auth failure (#4690) 670f177 test: WebUI interaction test for page [DET-7894] (#4689) 595d129 refactor: test cases for `ActionDropdown` (#4699) d976eff chore: support enum sizes for avatar (#4686) 4b35836 test: add test cases for `string.ts` (#4679) 79caa52 test: create interaction tests for action dropdown [DET-7895] (#4684) db50ba9 test: add test coverage for shared error utilities [DET-7900] (#4666) 4ef7c9a test: add test cases for `Image.tsx` (#4667) 15ae2fb test: add test cases for `Icon.tsx` (#4664) b034f79 test: add unit tests for logger class [DET-7901] (#4674) 143376d test: utils/set unit tests [DET-7904] (#4655) 4d6f13a fix: description overflowing table cell (#4656) 319f4fd test: add test cases for `AvatarCard` (#4650) 99511ed style: fix avatar card for long names (#4644) 81c3527 style: fix disabled primary button style (#4645) 5c1f8a9 style: update account layout [ET-7829] (#4627) 0d6a9db feat: User management list view [DET-7796] (#4607) 1e03b70 chore: allow setting context type for useModal (#4612) 8e48b29 ci: test downstream (#4604) 6dba773 chore: add attr to track api state has been initialized (#4599) 0fd1b58 chore: share useModal hook [DET-7781] (#4571) 3469630 style: fix spacing for tabs and headers [DET-7823] (#4595) 75938d9 fix: ignore order for Set isEqual [DET-7822] (#4589) 0dda86e fix: storybook rendering issue (#4554) 2491273 chore: eslint keyword spacing (#4561) fc1d9e0 chore: update eslint array multiline and add eslint arrow paren (#4562) c000e69 test: update avatar tests to remove warnings (#4523) 3e3444c feat: add props to style avatar differently (#4514) b5e2359 test: set up shared web to test with local strategy (#4504) 3c06bc4 test: fix local time tests (#4503) 9a18ebc chore: add helpers for working with shared-code (#4452) 023f425 style: theme tuning [DET-7362, DET-7363, DET-7364, DET-7365, DET-7366, DET-7383, DET-7425, DET-7498, DET-7551] (#4378) c735c5f feat: persist user web setting [DET-7501] (#4394) 6d3b431 test: update ci job for testing shared-code (#4444) 6299bb5 fix: trim workspace and project name whitespace [DET-7390] [DET-7747] (#4451) cf59394 chore: share AvatarCard and Avatar comps [DET-7714 DET-7713] (#4430) 4d8b880 fix: various workspaces fixes (#4443) 0e8ec69 feat: experiment comparison page (#4410) e5d277c test: resolve `useCustomizeColumnsModal` test flakes [DET-7635] (#4433) git-subtree-dir: webui/react/src/shared git-subtree-split: 0e135bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
addressing lack of contrast between text/background for avatars in light mode.
duplicate of #5066 on upstream branch
Test Plan
nothing to test in core since
noColorprop is only used in SaaS.Commentary (optional)
can test in storybook and SaaS to see that in light mode with
noColormode, text is dark instead of white:Checklist
docs/release-notes/.See Release Note for details.
/webui/react/src/shared/verifymake -C webui/react test-sharedpasses.