Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: usePolling on fetchMyRoles [WEB-3] #5204

Merged
merged 1 commit into from
Oct 6, 2022
Merged

chore: usePolling on fetchMyRoles [WEB-3] #5204

merged 1 commit into from
Oct 6, 2022

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Oct 6, 2022

Description

Now that fetchMyRoles is called when we load Determined WebUI (#5185) , I am following the ticket to periodically request an update from the API for the relevant RBAC roles. In this code it is every 120 seconds, but it could be adjusted. We previously implemented polling on fetchUserSettings every 60 seconds.

Test Plan

When loading the WebUI with ?f_rbac=on, you should see an immediate request to permissions/summary, and a following request 120 seconds later.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.
  • If modifying /webui/react/src/shared/ verify make -C webui/react test-shared passes.

@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for storybook-det ready!

Name Link
🔨 Latest commit 19e1ca4
🔍 Latest deploy log https://app.netlify.com/sites/storybook-det/deploys/633f213e0a099f0009d0e4b6
😎 Deploy Preview https://deploy-preview-5204--storybook-det.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 19e1ca4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/633f213e014fae0008444ca1
😎 Deploy Preview https://deploy-preview-5204--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mapmeld mapmeld merged commit 8a7e799 into determined-ai:master Oct 6, 2022
@mapmeld mapmeld deleted the polling_my_roles branch October 6, 2022 18:50
@dannysauer dannysauer added this to the 0.19.6 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants