fix: Roles should be fetched immediately when logging in #5229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue noticed by @ioga where it took a bit to populate roles when logging in. This happened because we immediately fetch roles when the page loads then poll for them on an interval; the initial call fails because the user is not yet logged in. There are broader problems with this method of data fetching but I'm not addressing those in this PR.
Specifically for roles I added a fetch when a user logs in.
Test Plan
Commentary
It seems to me that we might need to all of these fetches to the login action. Were these working correctly before rbac? Did the API maybe not check if you were logged in prior to rbac when performing certain GETs?
Checklist
docs/release-notes/
.See Release Note for details.
/webui/react/src/shared/
verifymake -C webui/react test-shared
passes.Ticket
No ticket