chore: add FieldMask type to apiutils #5247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
✅ Deploy Preview for storybook-det canceled.
|
maxrussell
force-pushed
the
field-mask-type
branch
from
04a588c
to
6835725
Compare
ioga
approved these changes
Oct 13, 2022
| fields := strings.Split(field, ".") | ||
| if len(fields) > 1 { | ||
| // Continually re-slice the slice of fields to check if an ancestor of field was specified. | ||
| for fields = fields[:len(fields)-1]; len(fields) > 0; fields = fields[:len(fields)-1] { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While reviewing #5177, I noticed some ergonomic issues working with FieldMasks and wanted to help make that easier. In particular:
a.band should carry the semantics that a descendent field likea.b.cshould be considered in the field set.So I made a new type (with tests) that uses a map for containment checks and respects the listed FieldMask conventions.
Test Plan
No behavior should change as a result of this PR.