feat: implement feature switch [WEB-535] #5310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for storybook-det ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ClaireNeveu
reviewed
Oct 21, 2022
|
|
||
| return ( | ||
| <ul> | ||
| <li>{feature.isOn('trials_comparison') && 'trials_comparison'}</li> |
There was a problem hiding this comment.
So that this isn't reliant on the current set of feature switches you should do a cast:
const feature1 = 'feature1' as ValidFeature
const feature2 = 'feature2' as ValidFeatureThen you can test if feature1 is on and feature2 is off.
ioga
reviewed
Oct 21, 2022
| @@ -50,6 +50,8 @@ message GetMasterResponse { | |||
| string branding = 9; | |||
| // Feature flag for RBAC and user groups. | |||
| bool rbac_enabled = 10; | |||
| // List of features that is on. | |||
| repeated string feature_switches = 11; | |||
There was a problem hiding this comment.
can we please tag it as = 12? otherwise it'll conflict with this SaaS change we are yet to move to OSS.
gt2345
force-pushed
the
535-feature-switch
branch
from
b4c0e06
to
028304d
Compare
ClaireNeveu
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
This looks good to me. Please wait for approval from @ioga before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
feature_switchto master config, and every valid switch in the list is considered “on” for feature switching at front end.Test Plan
Add
feature_switchto master configVerify that
/masterreturn withfeatureSwitchCommentary (optional)
Checklist
docs/release-notes/.See Release Note for details.