Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable tensorflow 2.5-2.7 tests. #5487

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Conversation

ioga
Copy link
Contributor

@ioga ioga commented Nov 28, 2022

Description

A bunch of nightlies have been failing due to shortage of k80. I believe we can omit TF tests for 2.5, 2.6, 2.7 to reclaim some capacity.

  • Real users now want newer versions of TF, not these.
  • Tests for 2.4 (our "legacy") and 2.8 (our "current") should cover functionality and compatibility well enough. These tests have never caught any issues past the initial release.
  • IIRC all our EE TF users are already on TF 2.8+

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 9369c0f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6384fd91eb445d0008a9c334

@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for storybook-det canceled.

Name Link
🔨 Latest commit 9369c0f
🔍 Latest deploy log https://app.netlify.com/sites/storybook-det/deploys/6384fd91c129a200082835c1

Copy link
Contributor

@mpkouznetsov mpkouznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminds me that we should stop building those environments.

@ioga ioga merged commit 1d8cda2 into determined-ai:master Nov 28, 2022
@dannysauer dannysauer added this to the 0.19.8 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants