-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Split UserRoles out of Store #5549
Conversation
✅ Deploy Preview for storybook-det ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
</WorkspacesProvider> | ||
</HelmetProvider> | ||
<UserRolesProvider> | ||
<HelmetProvider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small change, but can <UserRolesProvider>
be nested inside of <HelmetProvider>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the ordering of this doesn't matter; I saw the Settings.test has this too
ok it looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, noting we think init userRole is no longer needed
@@ -28,7 +28,6 @@ interface State { | |||
omnibar: OmnibarState; | |||
}; | |||
userAssignments: UserAssignment[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason we want to keep userAssignments
in old Store?
Description
chore: Split UserRoles out of Store WEB-585
This splits UserRoles and UserAssignments into their own store.
Test Plan
WebUI
open the console and ensure there are no errors related to permissions.rbac
feature flag using?f_rbac=on
. Ensure there is a501
error due to/api/v1/permissions/summary
and the UI still loads correctly.Commentary (optional)
I have removed the initialization of the user roles that was:
please let me know if that needs to be restored.
Checklist
- [ ] User-facing API changes need the "User-facing API Change" label.- [ ] Release notes should be added as a separate file underdocs/release-notes/
.See Release Note for details.
- [ ] Licenses should be included for new code which was copied and/or modified from any external code.