Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix spinner after logout #5572

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Conversation

thiagodallacqua-hpe
Copy link
Contributor

@thiagodallacqua-hpe thiagodallacqua-hpe commented Dec 9, 2022

Description

Fix the "infinite spinner" blocking the login screen.

Test Plan

using the anonymous tab:

  • if authenticated, log out and refresh the page. It should show the login page after the spinner
    • do the login flow
    • it should show the main page after login
  • if un-authenticated, it should still show the login page after the spinner

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for storybook-det ready!

Name Link
🔨 Latest commit 0d8c4f6
🔍 Latest deploy log https://app.netlify.com/sites/storybook-det/deploys/6393829e5d12840009a78cc1
😎 Deploy Preview https://deploy-preview-5572--storybook-det.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 0d8c4f6
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6393829efe9ed20009077d8e

@thiagodallacqua-hpe thiagodallacqua-hpe marked this pull request as ready for review December 9, 2022 17:52
@thiagodallacqua-hpe thiagodallacqua-hpe enabled auto-merge (squash) December 9, 2022 17:52
Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not working. This lets me see the login page, but after entering my information I go into the same loading state. Refreshing then brings me back to the login page.

webui/react/src/stores/auth.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, still broken. It's back to the original problem where I can't even load the login screen.

@EmilyBonar EmilyBonar dismissed their stale review December 9, 2022 18:55

Problems addressed

@thiagodallacqua-hpe thiagodallacqua-hpe merged commit ead8c10 into master Dec 9, 2022
@thiagodallacqua-hpe thiagodallacqua-hpe deleted the thiago/spinner-hotfix branch December 9, 2022 19:09
@dannysauer dannysauer added this to the 0.19.9 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants