-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: upload test results to datadog #8910
test: upload test results to datadog #8910
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8910 +/- ##
==========================================
- Coverage 47.53% 47.53% -0.01%
==========================================
Files 1066 1066
Lines 170433 170433
Branches 2237 2237
==========================================
- Hits 81018 81017 -1
- Misses 89257 89258 +1
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I want to complain about that really long line, but I think I'm the only person in the company who still insists on 80 columns. 👴 And it's nice to group stuff together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still approved. :D
7100b62
to
d7d4a07
Compare
I love 80-length lines. Kids these days don't know what's good. |
* upload to data dog for e2e tests * yaml syntax * try pytest DD integration * pytest syntax * more compiler errors * move install to install place * move to test requirements
Description
INFRAENG-363 is exploring test metrics for Determined-AI. We have a running trial for data dog right now.
Test Plan
Test results flow to DataDog for this branch - Pass
Commentary (optional)
Followed setup instruction but set ddtrace in the requirements rather than doing an ad-hoc pip install.
https://app.datadoghq.com/ci/setup/test?framework=pytest&language=python
Checklist
docs/release-notes/
.See Release Note for details.
Ticket
INFRAENG-363