-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump cpu image to latest ubuntu 2004 #8940
Conversation
✅ Deploy Preview for determined-ui canceled.
|
9875ce4
to
6fa756a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8940 +/- ##
==========================================
- Coverage 47.22% 42.40% -4.82%
==========================================
Files 1162 1010 -152
Lines 175913 164396 -11517
Branches 2237 2237
==========================================
- Hits 83069 69708 -13361
- Misses 92686 94530 +1844
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
not sure how to update the image for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small comment
@@ -31,7 +31,7 @@ parameters: | |||
default: determinedai/cimg-base:latest | |||
machine-image: | |||
type: string | |||
default: ubuntu-2004:202201-02 | |||
default: ubuntu-2004:2024.01.1 | |||
gpu-machine-image: | |||
type: string | |||
default: ubuntu-2004-cuda-11.2:202103-01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This GPU image also looks a bit older. Do you know if it ok or does it need an upgrade too?
Edit - probably good just to upgrade now
https://discuss.circleci.com/t/linux-cuda-deprecation-and-image-policy/48568
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree I considered it but I wasn't sure about the side effects and I want get these changes in asap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djanicekpach There was this discussion on Slack: https://hpe-aiatscale.slack.com/archives/C04C9JXB1C2/p1709567985738729?thread_ts=1709565408.754739&cid=C04C9JXB1C2. Aside from that specific implication, which I may look into, I'll start a branch with a bulk upgrade to a more recent Ubuntu version and see how it goes.
This reverts commit 0c3b1d3.
https://circleci.com/developer/images?imageType=machine
Brownout Schedule and EOL
We will be conducting brownouts for the above images on the following dates and times.
4 March 2024
07:00 UTC → 11:00 UTC
13:00 UTC → 17:00 UTC
20:00 UTC → 00:00 UTC
Description
Test Plan
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket