Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump cpu image to latest ubuntu 2004 #8940

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Conversation

hamidzr
Copy link
Member

@hamidzr hamidzr commented Mar 4, 2024

https://circleci.com/developer/images?imageType=machine

Brownout Schedule and EOL
We will be conducting brownouts for the above images on the following dates and times.
4 March 2024
07:00 UTC → 11:00 UTC
13:00 UTC → 17:00 UTC
20:00 UTC → 00:00 UTC

Description

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Mar 4, 2024
Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 6fa756a
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65e5e805d47bfd0008bd6ab6

@hamidzr hamidzr force-pushed the hz-bump-ci-machine branch 2 times, most recently from 9875ce4 to 6fa756a Compare March 4, 2024 15:25
@hamidzr hamidzr changed the title bump cpu image to latest ubuntu 2004 build: bump cpu image to latest ubuntu 2004 Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.40%. Comparing base (592a566) to head (6fa756a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8940      +/-   ##
==========================================
- Coverage   47.22%   42.40%   -4.82%     
==========================================
  Files        1162     1010     -152     
  Lines      175913   164396   -11517     
  Branches     2237     2237              
==========================================
- Hits        83069    69708   -13361     
- Misses      92686    94530    +1844     
  Partials      158      158              
Flag Coverage Δ
harness 42.39% <ø> (-21.54%) ⬇️
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 239 files with indirect coverage changes

@hamidzr
Copy link
Member Author

hamidzr commented Mar 4, 2024

https://app.circleci.com/pipelines/github/determined-ai/determined/51903/workflows/a4e26de5-b46b-46e5-a7a3-5f2cf673593a/jobs/2316513/artifacts

not sure how to update the image for the ..package.. job or what it's currently using

@hamidzr hamidzr marked this pull request as ready for review March 4, 2024 15:43
@hamidzr hamidzr requested a review from a team as a code owner March 4, 2024 15:43
Copy link
Contributor

@djanicekpach djanicekpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small comment

@@ -31,7 +31,7 @@ parameters:
default: determinedai/cimg-base:latest
machine-image:
type: string
default: ubuntu-2004:202201-02
default: ubuntu-2004:2024.01.1
gpu-machine-image:
type: string
default: ubuntu-2004-cuda-11.2:202103-01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This GPU image also looks a bit older. Do you know if it ok or does it need an upgrade too?
Edit - probably good just to upgrade now
https://discuss.circleci.com/t/linux-cuda-deprecation-and-image-policy/48568

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree I considered it but I wasn't sure about the side effects and I want get these changes in asap

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djanicekpach There was this discussion on Slack: https://hpe-aiatscale.slack.com/archives/C04C9JXB1C2/p1709567985738729?thread_ts=1709565408.754739&cid=C04C9JXB1C2. Aside from that specific implication, which I may look into, I'll start a branch with a bulk upgrade to a more recent Ubuntu version and see how it goes.

@hamidzr hamidzr merged commit 967e41f into main Mar 4, 2024
70 of 84 checks passed
@hamidzr hamidzr deleted the hz-bump-ci-machine branch March 4, 2024 16:02
@julian-determined-ai julian-determined-ai added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Mar 4, 2024
NicholasBlaskey added a commit that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants