Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update default aux container limits and instance types #8959

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

erikwilson
Copy link
Contributor

Description

Reduces our default MaxAuxContainersPerAgent values to 16, so containers would have ~1gb each on these 16gb machines. Also change the default aws instance types to non-burstable m5 instance.

Test Plan

Launch a lot of aux containers. They should not crash.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@erikwilson erikwilson requested a review from a team as a code owner March 5, 2024 23:44
@erikwilson erikwilson requested a review from daranday March 5, 2024 23:44
@cla-bot cla-bot bot added the cla-signed label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.19%. Comparing base (63adae5) to head (6a7e5e2).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8959   +/-   ##
=======================================
  Coverage   47.19%   47.19%           
=======================================
  Files        1155     1155           
  Lines      175116   175116           
  Branches     2237     2237           
=======================================
  Hits        82648    82648           
  Misses      92310    92310           
  Partials      158      158           
Flag Coverage Δ
backend 42.37% <ø> (ø)
harness 63.71% <100.00%> (ø)
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/deploy/gcp/constants.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 6a7e5e2
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65e7ae62c9677a0008a55f39
😎 Deploy Preview https://deploy-preview-8959--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@erikwilson erikwilson requested review from ioga and stoksc March 5, 2024 23:45
Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikwilson erikwilson merged commit dcaa893 into main Mar 6, 2024
76 of 89 checks passed
@erikwilson erikwilson deleted the erikw/fix/aux-containers-per-agent branch March 6, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants