Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update performance test script for breaking Determined change #8961

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

Description

We broke some Determined code we are using. This updates this to use the new session stuff.

Test Plan

Perf test passes

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner March 6, 2024 14:24
@cla-bot cla-bot bot added the cla-signed label Mar 6, 2024
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 497ff74
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65e87d0d30f8a40008368c27

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.37%. Comparing base (191a144) to head (497ff74).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8961      +/-   ##
==========================================
- Coverage   47.37%   47.37%   -0.01%     
==========================================
  Files        1162     1162              
  Lines      176134   176134              
  Branches     2237     2235       -2     
==========================================
- Hits        83448    83442       -6     
- Misses      92528    92534       +6     
  Partials      158      158              
Flag Coverage Δ
backend 42.74% <ø> (-0.01%) ⬇️
harness 63.94% <ø> (-0.01%) ⬇️
web 42.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Contributor

@djanicekpach djanicekpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think the plan is to add a default password to deployments for security, so "" may not work at some point in the future.

@NicholasBlaskey
Copy link
Contributor Author

Looks good. I think the plan is to add a default password to deployments for security, so "" may not work at some point in the future.

This work has already taken place.

This connects to a cluster running locally within the cirleci pod so there is no security issue.

@NicholasBlaskey NicholasBlaskey merged commit 68017dd into main Mar 6, 2024
72 of 83 checks passed
@NicholasBlaskey NicholasBlaskey deleted the fix_failing_perf_test branch March 6, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants