Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add EditorRestricted role to rbac docs #8984

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented Mar 11, 2024

Description

Add RBAC documentation for EditorRestricted role. See implementation.

Test Plan

CI passes.

Ticket

DET-10173

@cla-bot cla-bot bot added the cla-signed label Mar 11, 2024
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Mar 11, 2024
@determined-ci determined-ci requested a review from a team March 11, 2024 14:36
Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 2f6c517
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65f1a542a1f1dc000826f69e

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth mentioning that the ModelRegistryViewer role is not listed here.
Happy to add it in this PR and just change the associated ticket description if you want! @tara-det-ai

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great find! yes please add it! thanks @amandavialva01 !

Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find on the missing documentation of the ModelRegistryViewer role.

@determined-ci determined-ci requested a review from a team March 12, 2024 16:18
@amandavialva01 amandavialva01 force-pushed the amanda/EditorRestrictedRoleDocs branch from 70b65c3 to 98cbd53 Compare March 12, 2024 16:30
@amandavialva01 amandavialva01 force-pushed the amanda/EditorRestrictedRoleDocs branch 2 times, most recently from 2b071c8 to f8ef2e9 Compare March 12, 2024 20:31
@amandavialva01 amandavialva01 force-pushed the amanda/EditorRestrictedRoleDocs branch from f8ef2e9 to f595588 Compare March 12, 2024 20:31
@amandavialva01 amandavialva01 force-pushed the amanda/EditorRestrictedRoleDocs branch from 1c1c228 to 2f6c517 Compare March 13, 2024 13:08
@amandavialva01 amandavialva01 merged commit 89d4708 into main Mar 13, 2024
65 of 77 checks passed
@amandavialva01 amandavialva01 deleted the amanda/EditorRestrictedRoleDocs branch March 13, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants