Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change GKE version #8989

Merged
merged 1 commit into from
Mar 12, 2024
Merged

chore: change GKE version #8989

merged 1 commit into from
Mar 12, 2024

Conversation

amandavialva01
Copy link
Contributor

Description

Use major version prefix when specifying GKE version to avoid e2e failures upon removal of minor versions.

Test Plan

CI Passes e2e GKE tests

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@amandavialva01 amandavialva01 requested a review from a team as a code owner March 12, 2024 18:41
@cla-bot cla-bot bot added the cla-signed label Mar 12, 2024
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 0921fa3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65f0a1ceb92c07000853e03f
😎 Deploy Preview https://deploy-preview-8989--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.51%. Comparing base (cc2e9b4) to head (0921fa3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8989      +/-   ##
==========================================
+ Coverage   47.49%   47.51%   +0.01%     
==========================================
  Files        1168     1168              
  Lines      176296   176296              
  Branches     2352     2349       -3     
==========================================
+ Hits        83733    83761      +28     
+ Misses      92405    92377      -28     
  Partials      158      158              
Flag Coverage Δ
backend 42.65% <ø> (+0.06%) ⬆️
harness 64.01% <ø> (ø)
web 42.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@amandavialva01 amandavialva01 merged commit 0a2fd28 into main Mar 12, 2024
84 of 94 checks passed
@amandavialva01 amandavialva01 deleted the amanda/changeGKEVersion branch March 12, 2024 20:50
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants