chore: ban http.Transport & http.Client; add cleanhttp #8991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8991 +/- ##
==========================================
- Coverage 47.51% 47.49% -0.03%
==========================================
Files 1168 1168
Lines 176306 176306
Branches 2353 2351 -2
==========================================
- Hits 83765 83729 -36
- Misses 92383 92419 +36
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
carolinaecalderon
force-pushed
the
carolinac/add-cleanhttp-lint
branch
from
62cc1ce
to
fa38b95
Compare
carolinaecalderon
changed the title
carolinaecalderon
force-pushed
the
carolinac/add-cleanhttp-lint
branch
from
fa38b95
to
37ba5b7
Compare
stoksc
approved these changes
Mar 13, 2024
master/.golangci.yml
Outdated
| @@ -79,6 +79,8 @@ linters-settings: | |||
| - 'fmt\.Print.*' | |||
| - 'metaV1.NamespaceAll' # Will error if someone has namespace restricted permissions. | |||
| - 'bundebug.WithVerbose' | |||
| - 'http.Client' # Instead, we encourage use of cleanhttp. | |||
There was a problem hiding this comment.
Suggested change
| - 'http.Client' # Instead, we encourage use of cleanhttp. | |
| - 'http.Client' # Use cleanhttp instead. |
it is more than encouraged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ban use of
http.Transportandhttp.Clientin the codebase. Instead, usecleanhttplibrary.Test Plan
Pass existing tests.
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket
RM-85